Quantcast

[jira] [Created] (OPENJPA-2135) Deprecate prepareForPooling

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Created] (OPENJPA-2135) Deprecate prepareForPooling

JIRA jira@apache.org
Deprecate prepareForPooling
---------------------------

                 Key: OPENJPA-2135
                 URL: https://issues.apache.org/jira/browse/OPENJPA-2135
             Project: OpenJPA
          Issue Type: Improvement
          Components: jdbc, performance
    Affects Versions: 2.3.0, 2.2.1
            Reporter: Kevin Sutter
            Assignee: Kevin Sutter


Now that we have determined that closing Connections was overkill during the prepareForPooling processing when ConnectionRetainMode is set to "always" (OPENJPA-2134), maybe it's time to kill the whole idea of prepareForPooling.  If application servers are doing their job correctly, all that should be necessary is to call clear() on the EntityManager before pooling an EM.  Instead of removing this public API immediately, I'm thinking we should mark it as deprecated (just in case any app servers are still dependent on this processing).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Updated] (OPENJPA-2135) Deprecate prepareForPooling

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/OPENJPA-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Sutter updated OPENJPA-2135:
----------------------------------

    Issue Type: Sub-task  (was: Improvement)
        Parent: OPENJPA-2134
   

> Deprecate prepareForPooling
> ---------------------------
>
>                 Key: OPENJPA-2135
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2135
>             Project: OpenJPA
>          Issue Type: Sub-task
>          Components: jdbc, performance
>    Affects Versions: 2.3.0, 2.2.1
>            Reporter: Kevin Sutter
>            Assignee: Kevin Sutter
>
> Now that we have determined that closing Connections was overkill during the prepareForPooling processing when ConnectionRetainMode is set to "always" (OPENJPA-2134), maybe it's time to kill the whole idea of prepareForPooling.  If application servers are doing their job correctly, all that should be necessary is to call clear() on the EntityManager before pooling an EM.  Instead of removing this public API immediately, I'm thinking we should mark it as deprecated (just in case any app servers are still dependent on this processing).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Loading...