Quantcast

[jira] [Created] (OPENJPA-2171) asm should be optional

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Created] (OPENJPA-2171) asm should be optional

JIRA jira@apache.org
asm should be optional
----------------------

                 Key: OPENJPA-2171
                 URL: https://issues.apache.org/jira/browse/OPENJPA-2171
             Project: OpenJPA
          Issue Type: Improvement
            Reporter: Romain Manni-Bucau


openjpa uses since some versions asm but in tomee for instance we use a shade (through the xbean one org.apache.xbean:xbean-asm-shaded to avoid classloading/version issues with webapps/applications.

it can be nice if openjpa can provide us an issue to this because we really don't want to provide asm in our binaries.

solutions can be to use the xbean shade, give us an interface to implement or to try several implementation (xbean shade, asm,...) by reflection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (OPENJPA-2171) asm should be optional

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/OPENJPA-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253400#comment-13253400 ]

Kevin Sutter commented on OPENJPA-2171:
---------------------------------------

Can you help us understand the basic issue so that we can resolve this appropriately?  Is the basic issue because OpenJPA has introduced a maven dependency on ASM 3.2?  Or, is it due to the fact that we have now included the asm binaries in our openjpa-all jar file?  And, are those asm binaries causing conflicts with asm usage by TomEE?  I looked at the maven shade plugin (http://maven.apache.org/plugins/maven-shade-plugin/), but I'm wondering how that would affect those OpenJPA users that are okay with our current setup.  For example, other OpenJPA users could be using our jar file that does not contain all of the dependencies and just substitute their own copies (for example, the consumer is already using asm 3.2, so we're good to go).  Do users of the shade plugin end up providing both shaded and non-shaded versions of the jar files?  And, why is ASM the concern?  Wouldn't this same concern apply to other open-source dependencies that are specified (apache commons, derby, etc)?

Just looking for some more background and justification for this type of change.  Thanks.
               

> asm should be optional
> ----------------------
>
>                 Key: OPENJPA-2171
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2171
>             Project: OpenJPA
>          Issue Type: Improvement
>            Reporter: Romain Manni-Bucau
>
> openjpa uses since some versions asm but in tomee for instance we use a shade (through the xbean one org.apache.xbean:xbean-asm-shaded to avoid classloading/version issues with webapps/applications.
> it can be nice if openjpa can provide us an issue to this because we really don't want to provide asm in our binaries.
> solutions can be to use the xbean shade, give us an interface to implement or to try several implementation (xbean shade, asm,...) by reflection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (OPENJPA-2171) asm should be optional

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/OPENJPA-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253409#comment-13253409 ]

Romain Manni-Bucau commented on OPENJPA-2171:
---------------------------------------------

the issue is mainly tomee uses it in common classloader of tomcat and any user can need to provide a different version of asm (for a spring webapp for instance). as this issue is common Geronimo shaded asm.

the goal of this issue is to simply the dependency of openjpa on objectweb asm library.

if a user depends on asm it will need to bring asm.

Maybe i was not clear but the idea is simply to replace a dependency by another one for openjpa so the classical dependencies mecanisms are not broken.
               

> asm should be optional
> ----------------------
>
>                 Key: OPENJPA-2171
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2171
>             Project: OpenJPA
>          Issue Type: Improvement
>            Reporter: Romain Manni-Bucau
>
> openjpa uses since some versions asm but in tomee for instance we use a shade (through the xbean one org.apache.xbean:xbean-asm-shaded to avoid classloading/version issues with webapps/applications.
> it can be nice if openjpa can provide us an issue to this because we really don't want to provide asm in our binaries.
> solutions can be to use the xbean shade, give us an interface to implement or to try several implementation (xbean shade, asm,...) by reflection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (OPENJPA-2171) asm should be optional

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/OPENJPA-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256471#comment-13256471 ]

Romain Manni-Bucau commented on OPENJPA-2171:
---------------------------------------------

FYI: patched openejb/tomee version: http://svn.apache.org/repos/asf/openejb/trunk/patched-libraries/openjpa-all-asm-shaded/
               

> asm should be optional
> ----------------------
>
>                 Key: OPENJPA-2171
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2171
>             Project: OpenJPA
>          Issue Type: Improvement
>            Reporter: Romain Manni-Bucau
>
> openjpa uses since some versions asm but in tomee for instance we use a shade (through the xbean one org.apache.xbean:xbean-asm-shaded to avoid classloading/version issues with webapps/applications.
> it can be nice if openjpa can provide us an issue to this because we really don't want to provide asm in our binaries.
> solutions can be to use the xbean shade, give us an interface to implement or to try several implementation (xbean shade, asm,...) by reflection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (OPENJPA-2171) asm should be optional

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/OPENJPA-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256474#comment-13256474 ]

Jean-Louis MONTEIRO commented on OPENJPA-2171:
----------------------------------------------

Well, IMHO the issue is larger than just TomEE. The point is that a lot of projects uses ASM (Hibernate, OpenJPA, Spring, CXF, etc ...). But almost all of them uses a different version which can lead to hard classloading issues to solve. I can remember pulling my hair out because of that.

Even out TomEE, a webapp can face the same issue.

If you could provide an ASM-shaded jar of OpenJPA, that could help solving such an issue.

wdyt?

               

> asm should be optional
> ----------------------
>
>                 Key: OPENJPA-2171
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2171
>             Project: OpenJPA
>          Issue Type: Improvement
>            Reporter: Romain Manni-Bucau
>
> openjpa uses since some versions asm but in tomee for instance we use a shade (through the xbean one org.apache.xbean:xbean-asm-shaded to avoid classloading/version issues with webapps/applications.
> it can be nice if openjpa can provide us an issue to this because we really don't want to provide asm in our binaries.
> solutions can be to use the xbean shade, give us an interface to implement or to try several implementation (xbean shade, asm,...) by reflection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Assigned] (OPENJPA-2171) asm should be optional

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/OPENJPA-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Struberg reassigned OPENJPA-2171:
--------------------------------------

    Assignee: Mark Struberg
   

> asm should be optional
> ----------------------
>
>                 Key: OPENJPA-2171
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2171
>             Project: OpenJPA
>          Issue Type: Improvement
>            Reporter: Romain Manni-Bucau
>            Assignee: Mark Struberg
>
> openjpa uses since some versions asm but in tomee for instance we use a shade (through the xbean one org.apache.xbean:xbean-asm-shaded to avoid classloading/version issues with webapps/applications.
> it can be nice if openjpa can provide us an issue to this because we really don't want to provide asm in our binaries.
> solutions can be to use the xbean shade, give us an interface to implement or to try several implementation (xbean shade, asm,...) by reflection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (OPENJPA-2171) asm should be optional

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/OPENJPA-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408602#comment-13408602 ]

Mark Struberg commented on OPENJPA-2171:
----------------------------------------

I'll try to take a look at this today.
               

> asm should be optional
> ----------------------
>
>                 Key: OPENJPA-2171
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2171
>             Project: OpenJPA
>          Issue Type: Improvement
>            Reporter: Romain Manni-Bucau
>            Assignee: Mark Struberg
>
> openjpa uses since some versions asm but in tomee for instance we use a shade (through the xbean one org.apache.xbean:xbean-asm-shaded to avoid classloading/version issues with webapps/applications.
> it can be nice if openjpa can provide us an issue to this because we really don't want to provide asm in our binaries.
> solutions can be to use the xbean shade, give us an interface to implement or to try several implementation (xbean shade, asm,...) by reflection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Updated] (OPENJPA-2171) asm should be optional

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/OPENJPA-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Romain Manni-Bucau updated OPENJPA-2171:
----------------------------------------

    Attachment: ASM.patch

a patch using reflection to be able to use asm, xbean-asm or spring-asm
               

> asm should be optional
> ----------------------
>
>                 Key: OPENJPA-2171
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2171
>             Project: OpenJPA
>          Issue Type: Improvement
>            Reporter: Romain Manni-Bucau
>            Assignee: Mark Struberg
>         Attachments: ASM.patch
>
>
> openjpa uses since some versions asm but in tomee for instance we use a shade (through the xbean one org.apache.xbean:xbean-asm-shaded to avoid classloading/version issues with webapps/applications.
> it can be nice if openjpa can provide us an issue to this because we really don't want to provide asm in our binaries.
> solutions can be to use the xbean shade, give us an interface to implement or to try several implementation (xbean shade, asm,...) by reflection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Resolved] (OPENJPA-2171) asm should be optional

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/OPENJPA-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Struberg resolved OPENJPA-2171.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.3.0

slightly tweaked the patch and applied it to trunk

Thanks to rmannibucau for providing the fix!
               

> asm should be optional
> ----------------------
>
>                 Key: OPENJPA-2171
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2171
>             Project: OpenJPA
>          Issue Type: Improvement
>            Reporter: Romain Manni-Bucau
>            Assignee: Mark Struberg
>             Fix For: 2.3.0
>
>         Attachments: ASM.patch
>
>
> openjpa uses since some versions asm but in tomee for instance we use a shade (through the xbean one org.apache.xbean:xbean-asm-shaded to avoid classloading/version issues with webapps/applications.
> it can be nice if openjpa can provide us an issue to this because we really don't want to provide asm in our binaries.
> solutions can be to use the xbean shade, give us an interface to implement or to try several implementation (xbean shade, asm,...) by reflection

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Loading...